Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unneeded setting of int_ncid by libhdf5 layer #1445

Merged
merged 3 commits into from
Aug 5, 2019
Merged

removed unneeded setting of int_ncid by libhdf5 layer #1445

merged 3 commits into from
Aug 5, 2019

Conversation

edwardhartnett
Copy link
Contributor

Part of #1426

In this PR I remove the setting of int_ncid by libhdf5 code. This turns out to be unnecessary.

This is useful both to reduce code clutter and confusion, and also because this was the only use of the NC structure in the HDF5 code.

@edwardhartnett edwardhartnett requested a review from WardF as a code owner July 28, 2019 19:45
@edhartnett
Copy link
Contributor

@WardF it would be good to get this merged soon. There's two more PRs that follow...

@WardF WardF merged commit abfec2e into Unidata:master Aug 5, 2019
@edhartnett edhartnett deleted the ejh_notnc4_funcs branch August 13, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants