final batch of changes for netcdf_dispatch.h #1452

edhartnett · 2019-08-04T00:38:31Z

This is the final round of changes to netcdf_dispatch.h for the 4.7.1 release.

I have added some filer functions for dispatch tables (like PIO) that don't need to implement the full set of netcdf-4 functions.

This includes the changes in PR #1450

edwardhartnett · 2019-08-05T17:04:23Z

@WardF can you restart these tests to see if we can get past the dap testing?

edwardhartnett · 2019-08-06T01:21:07Z

Thanks!!

edhartnett added 23 commits July 28, 2019 13:43

removed unneeded setting of int_ncid by libhdf5 layer

fb54bf7

comment fix

9d128c3

adding missing semicolon

abfec2e

turned off broken dap test tst_zero_len_var.sh

6820f41

whitespace cleanup of hdf5open.c, plus extra documentation

f410b31

removed need for NC4_open to have NC passed in

e71ff09

have pnetcdf look up NC pointer for create

f80b751

removed need of NC pointer in create for pnetcdf dispatch layer

5fa67eb

now libhdf4 layer also looks up the NC on open

ef9b459

turned off tst_zero_len_var.sh in cmake build

659939d

now looking up NC in the libsrc dispatch layer open/create

64f983e

removed NC from open in dispatch table

170c5b0

clean up

49dcb48

clean up

cb3101c

fixed spacing

fc1d9ba

turned dap test back on

ad086e2

adding, and starting to use nc4_file_list_add()

181f260

now have libhdf5 use nc4_file_list_add()

7ce322a

merged master

f724bb7

whitespace cleanup

3c9a25b

fixed prototype

d1ddc92

more changes in support of user-defined formats

83c6cd5

more changes for user-defined formats

3a9207d

edhartnett requested a review from WardF as a code owner August 4, 2019 00:38

fixed comment to trigger CI

80542c0

WardF merged commit e5c171b into Unidata:master Aug 5, 2019

edhartnett deleted the ejh_ncint_3 branch August 13, 2019 17:12

Provide feedback