Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete _CRAYMPP and LOCKNUMREC macros #1464

Merged
merged 22 commits into from
Aug 21, 2019

Conversation

edhartnett
Copy link
Contributor

@edhartnett edhartnett commented Aug 14, 2019

Fixes #1459.

The obsolete macros _CRAYMPP and LOCKNUMREC were in use on an ancient version of a Cray. They would no longer work on modern Crays, which use MPI and the nc_open_par/nc_create_par functions for parallel I/O.

This will have no effect on existing users, since no could build with these macros - they are not supported in the configure.ac file.

This PR contains PR #1463, and should be inspected after that one is merged.

@edhartnett edhartnett requested a review from WardF as a code owner August 14, 2019 12:56
@edhartnett
Copy link
Contributor Author

Travis failed due to:
[0;31mFAIL�[m: tst_zero_len_var.sh

I'll commit a change to this branch and try again.

@edhartnett edhartnett mentioned this pull request Aug 21, 2019
@WardF WardF added this to the 4.7.1 milestone Aug 21, 2019
@WardF WardF merged commit 207f2b5 into Unidata:master Aug 21, 2019
@edhartnett edhartnett deleted the ejh_next branch September 3, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all references to very obsolete _CRAYMPP and LOCKNUMREC macros
2 participants