Allow nc_inq_var_szip() to return NC_NOERR and zero for parameters for vars without szip, also added parallel szip test #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This failed travis due to the test_byterange.sh test. Probably network timeout. I will update the branch to launch another travis run... |
|
I'm going to take this PR down. These changes are included in later PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well this szip stuff was more of a can of worms than I expected! However, as my first boss used to say: "Anything worth doing is worth doing right." ;-)
In this PR we allow nc_inq_var_szip() to return success and zeros for parameters if szip is not on for the var. This matches the behavior of the API with the other filters. It is not an error to do an inq on a filter, even if the filter is not present.
Also renamed test tst_parallel_zlib2.c to tst_parallel_compress.c, and added a szip test that will only be run of szip is present in HDF5, and parallel filters are allowed.
Also fixed the incorrect location of the AC_SUBST call which was causing problems for non-netcdf-4 builds.
Also more documentation to help explain and capture all the fun twists and turns of szip use.
This PR includes #1619 and #1623
Fixes #1622
Fixes #1618