Github issue 152: https://github.com/Unidata/netcdf-c/issues/152 #164
Conversation
User request to have all orphaned DAP2 attributes kept as netcdf global attributes. This is primarily a change in the oc code nplus testcase dataset changes. Result may be inconsistent with netcdf-Java output.
|
Is the fact that this is inconsistent with netcdf-java a showstopper? Copying @lesserwhirls , @JohnLCaron for their input. |
|
I don't know. The effect is to make attributes appear Ward Fisher wrote:
|
|
I checked the java code and it turns out that it already handles these |
|
Fantastic :). Merging shortly. |
Github issue #152 requested that "orphaned" DAS attributes be included in the netcdf metadata as global variables. The term orphaned here meant that they were not connected to any variable in the DDS. This was done in pull request #164 However, some servers (e.g. Thredds) include attributes for variables not specified in a constraint expression, but which exist in the full DDS. So I was adding these to the set of global attributes, but in retrospect this should not have been done: they should have been elided. Solution: modify oc2 code to be more distriminatory about which orphaned attributes to include.
User request to have all orphaned DAP2 attributes kept as netcdf
global attributes. This is primarily a change in the oc code
nplus testcase dataset changes.
Result may be inconsistent with netcdf-Java output.