Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m4 check in cmake provide a clear error when required but not available. #1740

Merged
merged 2 commits into from
Dec 7, 2020
Merged

m4 check in cmake provide a clear error when required but not available. #1740

merged 2 commits into from
Dec 7, 2020

Conversation

WardF
Copy link
Member

@WardF WardF commented May 26, 2020

WardF added 2 commits May 26, 2020 14:46
@WardF
Added a check for m4 and throw an error if m4 isn't on the path and t…
5961d6d 
…he generated file isn't present (as it would be in a point release). In support of #1739
@WardF
More m4 fenceposting.
3171219
@magnusuMET
Copy link
Contributor

Thanks for making the error message a lot clearer!

I think the check in libsrc/CMakeLists.txt fails as the files will only be created during build-time. The add_custom_command also takes a DEPENDS argument which should be ${CMAKE_CURRENT_SOURCE_DIR}/${filename}.m4 to ensure the build is rerun on a change of the .m4 files.

@WardF WardF mentioned this pull request Dec 7, 2020
Merged
@WardF WardF merged commit 6fafa66 into master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make m4 compile time dependency
2 participants
@WardF @magnusuMET