NetCDF-c Github issue #178 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetCDF-c Github issue #178 / esupport BNL-694121 The ncgen man pages says: > Note also that the words variable',dimension', data',group', and > `types' are legal CDL names, but be careful that there is a space be- > tween them and any following colon character when used as a variable > name. This is mostly an issue with attribute declarations. Ncdump does not obey this rule. The fix is to modify ncdump/ncdump.c to check if a variable name is a keyword. Also added test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetCDF-c Github issue #178 / esupport BNL-694121
The ncgen man pages says:
Ncdump does not obey this rule.
The fix is to modify ncdump/ncdump.c to check if a variable name is
a keyword.
Also added test case.