Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCZarr is outputting fill value as an array instead of a singleton. #2017

Merged
merged 2 commits into from
Jun 7, 2021
Merged

NCZarr is outputting fill value as an array instead of a singleton. #2017

merged 2 commits into from
Jun 7, 2021

Commits on Jun 5, 2021

  1. NCZarr is outputting fill value as an array instead of a singleton. 

    re: Unidata#2008

The fill_value key in a .zarray should have a single value,
but it currently has a value that is a 1 element array.
Fix is to pull out the single element.

This occurred because the fill_value is taken from the _FillValue attribute,
and all netcdf attributes are stored as arrays, of length 1 in this case.

In a related change, any attribute with length 1 is now stored in .zattrs
as a singleton rather than an array of length 1. This make the generated
Zarr more consistent with other Zarr implementations.

Misc. other changes:

1. Fix bug in testpathcvt caused by the way various shells handle backslash escapes.
2. Fix bug in testauth where test for MSVC is wrong.
    @DennisHeimbigner
    DennisHeimbigner committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    1c3e864 View commit details
    Browse the repository at this point in the history

  2. Update release notes

    @DennisHeimbigner
    DennisHeimbigner committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    6f03935 View commit details
    Browse the repository at this point in the history