Avoid redefinition of strcasecmp under mingw-w64 #2102
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2083
NetCDF defines
strcasecmp
as a preprocessor macro on Windows platforms. This is probably needed for the Microsoft compilers, but the header files used by mingw-w64 compilers definestrcasecmp
as an inline function.If both the inline function and the macro definitions are used with gcc at high optimisation levels (specifically the flag
-foptimize-sibling-calls
, which is included by default at-O2
or higher), the OpenDAP tests hang.On mingw-w64, the macro
__MINGW32__
is defined in both 32-bit and 64-bit environments. If this macro is defined, the macro definition ofstrcasecmp
can be disabled, which avoids the hang when running OpenDAP tests.