tst_misc.sh: Fix hang in make check #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tst_misc.sh: Fix hang in make check
edwardhartnett
approved these changes
Dec 24, 2021
Dave-Allured
commented
Dec 24, 2021
There was a problem hiding this comment.
This bug was introduced accidentally after release 4.8.0, and included in 4.8.1.
Without this fix, when $NC_VLEN_NOTEST is null, the command "x" is executed unintentionally. On Mac, this goes to a binary executable related to X11 service that should not be run standalone. The result is hang in the middle of make check, until canceled manually.
|
Good catch. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix recent bug in tst_misc.sh that causes hang in make check.
Affects netcdf-c 4.8.1 on Mac.