Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move construction of VERSION file to end of the build #2527

Merged
merged 6 commits into from
Oct 11, 2022

Commits on Sep 20, 2022

  1. Configuration menu
    Copy the full SHA
    ff4f162 View commit details
    Browse the repository at this point in the history
  2. restore

    DennisHeimbigner committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    0c883b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70dd39d View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Configuration menu
    Copy the full SHA
    f8e80a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Configuration menu
    Copy the full SHA
    0f198c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Move construction of VERSION file to end of the build

    re: Unidata#2521
    
    Charlie Zender has discovered that the netcdf created file VERSION
    conflicts with the C++ version file on OSX case-insensitive file systems,
    and maybe other case-insensitvie file systems.
    
    Note:
    1. Cmake does not create the VERSION file
    2. The VERSION file is not installed
    3. It turns out that the VERSION file is not required by the autoconf build.
    
    It is possible that clients or package build system (e.g apt or brew)
    might use the VERSION file, so we cannot delete it altogether.
    
    So as a fix, we move the creation of the VERSION file to after the
    build is complete by inserting a all-local hook into netcdf-c/Makefile.am.
    
    # Misc. other changes
    1. Suppressed warning by making use of the systeminfo command contingent on the platform being Windows.
    DennisHeimbigner committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    52a4eca View commit details
    Browse the repository at this point in the history