Fix some distcheck problems with nczarr_test and dap4_test #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: Issue Unidata#2545 re: Issue Unidata#2544 1. Test nczarr_test/run_scalar.sh was incorrectly accessing ref_scalar.cdl. 2. Disable dap4 testing until fixed for netcdf-java.
|
Not sure why you are turning off dap4 testing - with your fix and my fixes everything should work fine... |
|
As part of fixing DAP4 for netcdf-java, I am also cleaning up the |
|
Just to refer back to my previous comment, the make distcheck issue was already fixed in the wellspring branch and will be propagated back to main when I return to town Tuesday. DAP4 related cleanup and changes should go in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: Issue #2545
re: Issue #2544