Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress nczarr_test/tst_unknown filter test #2557

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Suppress nczarr_test/tst_unknown filter test #2557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d37147d
Suppress nczarr_test/tst_unknown filter test (and its nczarr_test equ…
DennisHeimbigner Nov 15, 2022
887c22c
Update Release Notes
DennisHeimbigner Nov 15, 2022
53a3e9a
retry
DennisHeimbigner Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ This file contains a high-level description of this package's evolution. Release

#### Changes

* [Bug Fix] Fix a race condition when testing missing filters. See [Github #2557](https://github.com/Unidata/netcdf-c/pull/2557).
* [Bug Fix] Fix some race conditions due to use of a common file in multiple shell scripts . See [Github #2552](https://github.com/Unidata/netcdf-c/pull/2552).
* [Enhancement][Documentation] Add Plugins Quick Start Guide. See [GitHub #2524](https://github.com/Unidata/netcdf-c/pull/2524) for more information.
* [Enhancement] Add new entries in `netcdf_meta.h`, `NC_HAS_BLOSC` and `NC_HAS_BZ2`. See [Github #2511](https://github.com/Unidata/netcdf-c/issues/2511) and [Github #2512](https://github.com/Unidata/netcdf-c/issues/2512) for more information.
Expand Down
6 changes: 5 additions & 1 deletion nc_test4/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,13 @@ IF(USE_HDF5 AND ENABLE_FILTER_TESTING)
build_bin_test(tst_filter_avail)
build_bin_test(test_filter_vlen)
ADD_SH_TEST(nc_test4 tst_filter)
ADD_SH_TEST(nc_test4 tst_unknown)
ADD_SH_TEST(nc_test4 tst_specific_filters)
ADD_SH_TEST(nc_test4 tst_bloscfail)
IF(FALSE)
# This test is too dangerous to run in a parallel make environment.
# It causes race conditions. So suppress and only test by hand.
ADD_SH_TEST(nc_test4 tst_unknown)
ENDIF(FALSE)
ENDIF(USE_HDF5 AND ENABLE_FILTER_TESTING)

ENDIF(BUILD_UTILITIES)
Expand Down
4 changes: 3 additions & 1 deletion nc_test4/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,14 @@ extradir =
check_PROGRAMS += test_filter test_filter_misc test_filter_order test_filter_repeat test_filter_vlen
check_PROGRAMS += tst_multifilter tst_filter_avail
TESTS += tst_filter.sh
TESTS += tst_unknown.sh
TESTS += tst_specific_filters.sh
TESTS += tst_bloscfail.sh
if ISMINGW
XFAIL_TESTS += tst_filter.sh
endif # ISMINGW
# This test is too dangerous to run in a parallel make environment.
# It causes race conditions. So suppress and only test by hand.
#TESTS += tst_unknown.sh
endif # ENABLE_FILTER_TESTING
endif # USE_HDF5
endif # BUILD_UTILITIES
Expand Down