A small, but meaningful start, to addressing undefined behavior #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…running nc_test/nc_test, in support of Unidata#1983, amongst others. The cast as was being used was undefined behavior, and had to be worked around in a style approximating C++'s 'reinterpret_cast'
WardF
changed the title
DennisHeimbigner
previously approved these changes
Feb 21, 2023
Closed
1 task
…UNSIGNED_CHAR (255) to a variable of type char.
WardF
added a commit
to dopplershift/libnetcdf-feedstock
that referenced
this pull request
Feb 24, 2023
…relate to undefined behavior in nc_test, and (unsigned char) values being assigned to variables of type (char)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cast was resulting in undefined behavior, and had to be worked around in a style approximating C++'s 'reinterpret_cast'. This was discovered using the
-fsanitize=undefinedcompiler flag w/clang, and there is a lot of other work to be done. I am hoping that these fixes, when patched in tolibnetcdf-feedstock, will also address the issue observed at conda-forge/libnetcdf-feedstock#138.