Provide a single option to disable all network access and testing. #2708
+72
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the option "--disable-network-access" (automake) or "-DENABLE_NETWORK_ACCESS=OFF" (cmake). When disabled, this option transitively disables all network access capabilities and testing. If set, this option implies the following: * --disable-dap * --disable-byterange * --disable-s3 This PR answers a request for a feature from Ed Hartnett. ## Misc. Other changes * Take the opportunity to clean up some old, unused options; e.g. --enable-multifilters. * Fix bug in using S3 urls.
WardF
reviewed
Jun 12, 2023
There was a problem hiding this comment.
I'm concerned that 'network access' might be ambiguous; I can imagine questions, down the line, around 'what about networked drives? What about X?'. I think a single-switch shortcut which acts as a master switch to set existing remote data access options to off is a fine idea, but I wonder about overstating what it's doing.
WardF
reviewed
Jun 12, 2023
libnetcdf.settings.in
Outdated
| Quantization: @HAS_QUANTIZE@ | ||
| Logging: @HAS_LOGGING@ | ||
| SZIP Write Support: @HAS_SZLIB_WRITE@ | ||
| Standard Filters: @STD_FILTERS@ | ||
| ZSTD Support: @HAS_ZSTD@ | ||
| Parallel Filters: @HAS_PAR_FILTERS@ | ||
|
|
||
| Allow Network Access: @DO_NETWORK_ACCESS@ |
There was a problem hiding this comment.
I will make a change to this summary, I don't want to mislead or overstate what we're doing; 'Network Access' is ambiguous and can mean a lot.
…s in nc-config, and I can see where people might want to use this define to write code that works with modern and older versions of netCDF.
…ood, did it refer to networked drives? Other things that are network adjacent?
WardF
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option "--disable-network-access" (automake) or "-DENABLE_NETWORK_ACCESS=OFF" (cmake).
When disabled, this option transitively disables all network access capabilities and testing.
If set, this option implies the following:
This PR answers a request for a feature from Ed Hartnett.
Misc. Other changes