Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Setup a CMake job for MSYS2/MinGW #2917

Merged
merged 3 commits into from
May 15, 2024
Merged

CI: Setup a CMake job for MSYS2/MinGW #2917

merged 3 commits into from
May 15, 2024

Conversation

MehdiChinoune
Copy link
Contributor

No description provided.

@DennisHeimbigner
Copy link
Collaborator

This keeps dying on me because apparently m4 is not being installed.

@MehdiChinoune
Copy link
Contributor Author

This PR requires #2914 to be applied first.

@DennisHeimbigner
Copy link
Collaborator

Applied 2914 and it still dies because it cannot find m4.

@MehdiChinoune
Copy link
Contributor Author

Applied 2914 and it still dies because it cannot find m4.

It requires some more changes that i will apply one #2914 got merged.

@MehdiChinoune
Copy link
Contributor Author

@DennisHeimbigner I have pushed changes for the build to succeeds, but tests needs more changes to succeed.

@DennisHeimbigner
Copy link
Collaborator

You repeatedly change if(MSVC) to if(WIN32). Does that work for cygwin?

@MehdiChinoune
Copy link
Contributor Author

You repeatedly change if(MSVC) to if(WIN32). Does that work for cygwin?

No, WIN32 is not defined by CMake on CygWin.

@MehdiChinoune MehdiChinoune marked this pull request as ready for review May 7, 2024 04:00
@MehdiChinoune MehdiChinoune requested a review from WardF as a code owner May 7, 2024 04:00
@WardF
Copy link
Member

WardF commented May 7, 2024

@DennisHeimbigner I'm not seeing an issue on my end from the tests, but I don't have a Cygwin environment to run. It works in MSYS2 with Visual Studio, if you run this manually on your Cygwin environment, does it fail?

@DWesl
Copy link
Contributor

DWesl commented May 9, 2024

DWesl#2 is a copy of this workflow adapted for Cygwin, which shows a single test failure (a massive improvement over the last time I tried CMake on Cygwin). I don't recognize the reason for the nc_test4_tst_filter failure from the details provided, so I'd have to dig into that locally, but I suspect that failure is unrelated to the changes in this PR.

@DennisHeimbigner
Copy link
Collaborator

Can you give a short characterization of the differences between you cygwin .yml
and the existing cygwin .yml?

@DWesl
Copy link
Contributor

DWesl commented May 10, 2024

Can you give a short characterization of the differences between your cygwin.yml
and the existing cygwin.yml?

I added a section to build the software and run tests using CMake. This section differs from the Autotools job in the software installed (the CMake job adds gcc-g++, cmake, ninja, and make) and tool used to configure, build, and run the tests.

The CMake section differs from the CMake section here in the action used to install packages (Cygwin instead of MSYS/MinGW) and the build generator used (Unix Makefiles instead of MSYS). I also specified more full paths to utilities. Should I make a PR to add that to this PR or create a new PR?

@WardF WardF merged commit f8164e3 into Unidata:main May 15, 2024
106 checks passed
@WardF
Copy link
Member

WardF commented May 15, 2024

Thanks!

@MehdiChinoune MehdiChinoune deleted the ci-mingw branch May 15, 2024 03:12
@DWesl DWesl mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants