Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate definition when using aws-sdk-cpp. #2928

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix duplicate definition when using aws-sdk-cpp. #2928

merged 1 commit into from
May 22, 2024

Commits on May 21, 2024

  1. Fix duplicate definition when using aws-sdk-cpp. 

    re: Issue Unidata#2927

The NC_s3sdkinitialize NC_s3sdkfinalize functions were
misplaced. They should have been moved from ds3util.c to
ncs3sdk_h5.c.  When using ncs3sdl_aws.cpp, this resulted in a
duplicate definition.

Also, found and fixed a memory leak in the NCZarr S3 code.
    @DennisHeimbigner
    DennisHeimbigner committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9a478ed View commit details
    Browse the repository at this point in the history