-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add mode to read consolidated ZARR datasets #2992
Conversation
The way I planned to do the consolidated metada (aside: would like a shorter term than "consolidated") |
964be46
to
1d79947
Compare
How about using Personally, I would prefer to make consolidated the default, and fall back to unconsolidated, if no .zmetadata file is available (or the user explicitly asks for unconsolidated), but I would also understand if you prefer not to change existing behavior of libnetcdf... |
It occurs to me to ask. Why is the consolidated metadata in a separate .zmetadata rather than in the root groups' zarr.json? |
No idea why, but it is handled that way in zarr python for zarr2 ... See your question here: zarr-developers/zarr-python#720 |
You mean adding a block of function pointers to NC_Dispatch](https://github.com/Unidata/netcdf-c/blob/main/include/netcdf_dispatch.h.in#L34) that would handle the metadata(-file) operations for zarr? I was picturing something internal to to the NCZ_* layer but I don't have a really good overview of the code design. |
No, I was thinking of an internal dispatch table. When I added support |
I finally understood you're referring to the implementation in the branches of your fork! I'm taking a look into |
1d79947
to
e1e5c68
Compare
This changes add a mode option
mode=consolidated
(perhaps best to do it by default when reading and fallback if fails) that will fetch a possibly existing.zmetadata
file from the root of the dataset. That could serve as unified representation to be used whenever needing group or variable metadata further down the code path.This is a WIP motivated by #2987 and lacks (at least):
consolitaded
not available