Remove warnings from selected files #3071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can work with it. I will revise this PR description later. ### Notes: 1. It does not yet run on github actions without errors. 2. It appears to have no memory leaks 3. It has problems with the testing infrastructure that I am working on. 4. CMake does not work for testing v3_nczarr_test because of CMake Policy [CMP002](https://cmake.org/cmake/help/latest/policy/CMP0002.html). 5. Ubuntu + Automake appears to work including testing v3_nczarr_test. 6. make distcheck does not work because of difficulties with VPATH.
Add various casts etc to cleanup warnings from selected modules. The modules affected are as follows: * libdispatch * libncpoco * libnczarr * libsrc4 * nczarr_test Additionally, clean up some Zarr V3 dependencies in Makefile.am and configure.ac. Note: This PR is a delta on v3plug.dmh, so cannot be applied until that previous PR is applied.
H/T Manual Reis Also turn off some debugging output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add various casts etc to cleanup warnings from selected modules.
The modules affected are as follows:
Additionally, clean up some Zarr V3 dependencies in Makefile.am and configure.ac.
Note: This PR is a delta on v3plug.dmh, so cannot be applied until that previous PR is applied.