added fill mode and var rename tests #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this already in docs/attribute_conventions.md |
|
Fair enough. Want me to remove what I just added to the user manual? |
|
Assuming the attribute-conventions is not referenced in the guide, |
|
I have just left the documentation alone, in the end. This PR is ready to merge. There are some failures in travis due to the HDF5 plugin file copy issue. |
|
it is out of date wrt to master. Can you fix? |
|
@DennisHeimbigner have updated with master, will keep an eye on Travis tests to make sure they succeed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379.
Fixes #742.
Fixes #800.
The fill mode issue has actually been fixed for some time thanks to @wkliao. This PR adds a test which confirms that this works and continues to work.
The other test confirms that names are utf8 normalized during variable renames.
Also added documentation of attribute reserved names to users guide.