Consolidating Several PR's #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio 2013 and older do not support `inline` in C code.
Fix unused variable warning for `printid`. Looks like it was not substituted in all places where it should have been and was only used inside an ifdef so was unused if `LOGGING` was false. Add use in `fprintf` line following the ifdef block. Minor change, but compilation output is so clean that a little wart sticks out...
…o pr-consolidate.wif
…cdf-c into pr-consolidate.wif
|
Seeing a compiler fail under parallel; will push the fix shortly. |
DennisHeimbigner
approved these changes
May 8, 2018
|
Seeing a downstream issue in If the issue is non-trivial, will back out that particular PR. |
|
The issue with netcdf-fortran is external to this consolidation, so merging this and then looking at fortran. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting caught up on PR's, consolidating several into a single PR to avoid cascading CI checks.