-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quantize feature to F77 and F90 APIs, with tests and documentation #304
Conversation
OK, apparently no CI for netcdf-fortran yet. ;-) I added one based on branch ejh_quantize_2 of my fork of netcdf-c. Once those changes are merged this CI can be changed to use master branch of the official netcdf-c repo, or discarded in favor of better CI... |
Looks great, thanks @edwardhartnett! |
Ok, I spoke a little soon, although I'm not going to revert the PR because that could end up making more of a mess. However, trying to link against netCDF 4.8.1 gives the following:
So we will need to query for these functions at configure time and fencepost the code as appropriate. |
Problem is that many of the fortran codes don't actually have pre-processing. :-( So perhaps undoing the merge is a good idea... |
I'll take a look, thanks for weighing in. Reverting it out of the blue would possibly require jumping through hoops to re-apply it down the road. I'm going to revert it, get the testing in (I've got something working now, turns out the main issue was tabs in the yaml file XD), and see what we can do. Thanks! |
This won't work until the quantize PR in netcdf-c is merged (Unidata/netcdf-c#2088).
Add the quantize feature to the Fortran APIs.