Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API, part 1 #137

Merged
merged 13 commits into from
Oct 27, 2019
Merged

Public API, part 1 #137

merged 13 commits into from
Oct 27, 2019

Conversation

JohnLCaron
Copy link
Collaborator

@JohnLCaron JohnLCaron commented Oct 10, 2019

  1. Make the core objects (ucar.nc2., ucar.nc2.datatset.) immutable by adding builders.
  2. Mark mutating methods deprecated.
  3. Start to move static helpers to seperate class.
  4. Move/port non-public classes to ucar.nc2.internal.

This should not be submitted until 5.2 branch is released.
In any case theres a lot more to do.


This change is Reviewable

@JohnLCaron
Copy link
Collaborator Author

Ok, this is ready as soon as 5.2 is tagged.
Would be good to do asap so I can see the diffs for the next PR (coord system) which is pretty complicated. thanks

@lesserwhirls
Copy link
Collaborator

Awesome! 5.2 is now cut on 5.3.0-SNAPSHOT is on master. Would you mind rebasing?

@JohnLCaron
Copy link
Collaborator Author

JohnLCaron commented Oct 23, 2019 via email

@lesserwhirls
Copy link
Collaborator

Looks like just a spotless issue on the restored file. Once that's done we'll be good to go on this one.

@lesserwhirls lesserwhirls merged commit 2aa87a1 into Unidata:master Oct 27, 2019
@lesserwhirls
Copy link
Collaborator

I went ahead and applied spotless and pull this in over on #142. Thanks @JohnLCaron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants