Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.12, remove python 3.7 #1284

Merged
merged 3 commits into from
Oct 19, 2023
Merged

add python 3.12, remove python 3.7 #1284

merged 3 commits into from
Oct 19, 2023

Conversation

jswhit
Copy link
Collaborator

@jswhit jswhit commented Oct 19, 2023

No description provided.

@akrherz
Copy link

akrherz commented Oct 19, 2023

Note that miniconda.yml is not running

[Invalid workflow file: .github/workflows/miniconda.yml#L14](https://github.com/Unidata/netcdf4-python/actions/runs/6576298056/workflow)
You have an error in your yaml syntax on line 14

@@ -12,7 +12,7 @@ jobs:
# NO_NET: 1
strategy:
matrix:
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11" ]
python-version: [ "3.8", "3.9", "3.10", "3.11" "3.12" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: [ "3.8", "3.9", "3.10", "3.11" "3.12" ]
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]

@jswhit jswhit merged commit 130efb0 into master Oct 19, 2023
33 checks passed
@jswhit jswhit deleted the py312 branch October 19, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants