-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow _FillValue to be set using fill_value createVariable kwarg for vlen string vars #732
Conversation
vlen string variables.
test/tst_masked5.py
Outdated
self.assertTrue(isinstance(v[:], ma.core.MaskedArray)) | ||
assert_array_equal(v[:], self.v_ma) | ||
assert_array_equal(v[2],self.v[2]) # issue #624. | ||
v.set_auto_mask(False) | ||
self.assertTrue(isinstance(v[:], np.ndarray)) | ||
assert_array_equal(v[:], self.v) | ||
|
||
# issue 730 | ||
assert (v2[0]=='first') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be u'first'
for it to pass on both python 2/3. The rule of thumb is to always use bytes/unicode literals (b'first'
and u'first'
) unless you want native strings.
Looks like the travis tests are failing because they are using an older version of the netcdf-c library. I'll disable this test if the library version is < 4.4 |
No description provided.