allow _FillValue to be set using fill_value createVariable kwarg for vlen string vars #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlen string variables.
shoyer
reviewed
Oct 25, 2017
test/tst_masked5.py
Outdated
| self.assertTrue(isinstance(v[:], ma.core.MaskedArray)) | ||
| assert_array_equal(v[:], self.v_ma) | ||
| assert_array_equal(v[2],self.v[2]) # issue #624. | ||
| v.set_auto_mask(False) | ||
| self.assertTrue(isinstance(v[:], np.ndarray)) | ||
| assert_array_equal(v[:], self.v) | ||
|
|
||
| # issue 730 | ||
| assert (v2[0]=='first') |
There was a problem hiding this comment.
This should probably be u'first' for it to pass on both python 2/3. The rule of thumb is to always use bytes/unicode literals (b'first' and u'first') unless you want native strings.
|
Looks like the travis tests are failing because they are using an older version of the netcdf-c library. I'll disable this test if the library version is < 4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.