Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting python-training back to buiding #111

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

dcamron
Copy link
Member

@dcamron dcamron commented Aug 21, 2020

Alright here it is finally. This should be what we need to get Nikola and Travis happy together once again. I have plenty more I want to build off of this, but let's start here.

Highlights

  • Fix broken URLs
  • Reorganize some siphon catalog workflows along the way (more to do)
  • Move data/ out of pages/. Wasn't causing any problems before, but we were never saving any txt files. With the introduction of a few saved METARs, Nikola wasn't happy. There are probably prettier ways to organize any created/saved/opened files, but we'll get there later.
  • Temporarily hide some notebooks waiting on MetPy 1.0
  • Pin to Pandas<1.1.0 pending Fix indexing with datetime64[ns] with pandas=1.1 pydata/xarray#4292
  • Clear out some cftime conversion headaches

Along with some style, clarity, and organization tweaks to continue after getting this lad going. Should hopefully let us get to chewing through the backlog and revitalizing a roadmap for new ideas. Let's ship this off to Travis and see.

Main attempt at getting python-training back to building on Travis
before making any larger changes. Primarily fix broken TDS URLs and fix
syntax for building on MetPy 0.12.2 (preparing changes for 1.0). Took
the chance to also update style, cell organizations, and siphon
workflows for clarity. Update certain printouts and formatting. Plenty
of work to do from here but should get us running on Travis again
for now.
Saved METAR txt files in the pages directory throw off Nikola. I'm
sure there's a prettier way to re-organize this, but let's just get
python-training building again first.
@dcamron
Copy link
Member Author

dcamron commented Aug 21, 2020

Note that I still need to publicly present a few new submissions, including the notebooks with the METAR parsing that I made sure to have working, heh.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Nice to have things working again.

@dcamron dcamron merged commit 444bc79 into Unidata:master Aug 21, 2020
@dcamron dcamron deleted the url-fixes branch August 27, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants