This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Add some UDUnits of substance #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add avogadro_constant, molecule, and related units that are defined in UDUNITS 2.
|
Definition of "molecule" was added in UDUNITS 2.2.0 then redefined in 2.2.18; "nucleon" as a synonym for molecule appears in 2.2.12. Presumably "avogadro_constant" was added in 2.0. |
|
@semmerson - would you mind taking a look and providing feedback on this? |
|
Hi @msdsoftware - we're looking at making a udunits2 java package based on the grammar and xml units registry used in udunits2. In the meantime, we can add what's needed to the udunits package here in the THREDDS repo. Thanks for your contribution! |
|
Wonderful. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add avogadro_constant, molecule, and related units that are defined in UDUNITS 2.