This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
handle all coordinate transforms #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure all coordinate transforms get added to ncss response, even if they are not needed to compute latitude / longitude. This would include, for example, the LatLon_Projection, which is listed as the grid_mapping for some global GRIB datasets, but don't actually "do" a transform (no x/y -> lat/lon by netCDF-Java), as lat/lon are explicitly constructed from the GRIB message GSD). This ensures that we are following CF if a grid_mapping is listed (i.e. must include the transform variable). See Unidata/python-workshop#372 for details.
|
Not needed in 5.0, as |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all coordinate transforms get added to ncss response, even if
they are not needed to compute latitude / longitude. This would include,
for example, the LatLon_Projection, which is listed as the grid_mapping
for some global GRIB datasets, but don't actually "do" a transform (no
x/y -> lat/lon by netCDF-Java), as lat/lon are explicitly constructed
from the GRIB message GSD). This ensures that we are following CF if a
grid_mapping is listed (i.e. must include the transform variable).
See Unidata/python-workshop#372 for details.