This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
fix ncss page #1301
Merged
fix ncss page #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In xsl land, empty elements are output without closing tags when the output is html. This causes all kinds of issues with the table layout. By inserting a <span></span> within the empty <div>s used for holding ncss map previews, we keep the right table nesting, and we don't get a collision of the url builder row and the right column widgets. Thank you @ddirks for helping debug this madness!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
xslland, empty elements are output without closing tags when the output ishtml.This causes all kinds of issues with the table layout.
By inserting a
<span></span>within the empty<div>s used for holding ncss map previews, we keep the right table nesting, and we don't get a collision of the url builder row and the right column widgets.Thank you @ddirks for helping debug this madness