This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Fix inconsistent representation for Grib Level #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses Unidata#853 Grib1_Level_Type and Grib2_Level_Type were not consistent. Grib2_Level_Type was the String description of the level, which is actual the analog of Grib1_Level_Desc. Adds new attribute, Grib2_Level_Desc, and makes Grib2_Level_Type the integer code value, just link Grib1_Level_Type.
cwardgar
reviewed
Jun 9, 2017
| } | ||
| if (vindex.getLevelType() != GribNumbers.MISSING) | ||
| v.addAttribute(new Attribute("Grib2_Level_Type", vindex.getLevelType())); | ||
| String ldesc = cust.getLevelName(vindex.getLevelType()); |
There was a problem hiding this comment.
Should be cust.getLevelDescription
There was a problem hiding this comment.
Nevermind, it looks like that method doesn't exist on Grib2Customizer like it does on Grib1Customizer. Weird.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #853
Grib1_Level_Type and Grib2_Level_Type were not consistent. Grib2_Level_Type was
the String description of the level, which is actual the analog of Grib1_Level_Desc.
Adds new attribute, Grib2_Level_Desc, and makes Grib2_Level_Type the integer code
value, just link Grib1_Level_Type.