This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Allow default cache sizes of Variables to be modified by user. #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cwardgar
commented
Jul 10, 2017
cwardgar
commented
- Variables need to be static, public, and non-final.
- From the mailing list.
* Variables need to be static, public, and non-final.
| @@ -73,7 +73,7 @@ | |||
|
|
|||
| public class CoordinateAxis extends VariableDS { | |||
| static private org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(CoordinateAxis.class); | |||
| static private final int axisSizeToCache = 100 * 1000; // bytes | |||
| static public int axisSizeToCache = 100 * 1000; // bytes | |||
There was a problem hiding this comment.
I suppose there is no way to make this package private? If not, that's ok, just checking to make sure.
There was a problem hiding this comment.
Not if we want the user to easily be able to modify it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.