This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Make special attributes accessible by name only. #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re: git issue #948 Currently, special attributes like _NCProperties are visible when iterating thru the attributes of the root group. This pr changes that so that they are suppressed when using Group.getAttributes(). They can still be accessed by name using Group.findAttribute(String name). This change enforces the similar rule used in the netcdf-C library. Added a test dataset and a test case for this change.
DennisHeimbigner
added a commit
that referenced
this pull request
Nov 11, 2017
Re: git pull request #949 Re: git issue #948 This adds the change of pull request #949 to branch 5.0.0. Changes in 5.0 code make it impossible to cherry pick. From master pull request: Currently, special attributes like _NCProperties are visible when iterating thru the attributes of the root group. This pr changes that so that they are suppressed when using Group.getAttributes(). They can still be accessed by name using Group.findAttribute(String name). This change enforces the similar rule used in the netcdf-C library. Added a test dataset and a test case for this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: git issue #948
Currently, special attributes like _NCProperties are visible
when iterating thru the attributes of the root group.
This pr changes that so that they are suppressed when using
Group.getAttributes(). They can still be accessed by name using
Group.findAttribute(String name).
This change enforces the similar rule used in the netcdf-C library.
Added a test dataset and a test case for this change.