Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly formatting sent notifications #107

Open
hmpf opened this issue Aug 7, 2020 · 2 comments
Open

Properly formatting sent notifications #107

hmpf opened this issue Aug 7, 2020 · 2 comments
Labels
blocked Another thing/issue has to be resolved before tackling this enhancement New feature or request notification Affects the notification system
Milestone
New notification ...

Comments

@hmpf
Copy link
Contributor

hmpf commented Aug 7, 2020 •
edited by katsel
Loading

The styles currently in use for email and sms, is fine for dev but not very useful for production.

Email

Example, current email subject, before removal of object and parent_object:

"Incident at 2020-08-04 13:26:09.635804+00:00 [fre: fwfwrf: Object created via "create_fake_incident" (None) <ID >]

  • An email subject is preferably
    • max 50 characters long
    • most important things first

Having the timestamp that early is not good. Maybe...

Argus: fre: fwfwrf: Object created via "create_fake_incident" (None) <ID > 2020-08-04 13:26:09.635804+00:00

"Argus" might also not be necessary.

An email has a body where we could, if we wanted, put tons of stuff.

SMS

  • SMS is preferrably no longer than 160 characters, or it will be sent as an MMS.

Example, current experimental sms system, before removal of object and parent_object:

2020-08-04 13:26:09.635804+00:00 [fre: fwfwrf: Object created via "create_fake_incident" (None) <ID >]

I suspect we need to ask anticipated recipients what they would prefer...
@hmpf hmpf added enhancement New feature or request priority: low labels Aug 7, 2020
@hmpf
Copy link
Contributor Author

hmpf commented Sep 15, 2020

See #121

@hmpf hmpf added this to the blue sky milestone Sep 29, 2020
@hmpf hmpf added the notification Affects the notification system label Sep 29, 2020
@hmpf hmpf modified the milestones: Blue sky, New notification system Oct 2, 2020
@katsel katsel changed the title Styling sent notifications Properly formatting sent notifications Jan 19, 2021
@hmpf hmpf mentioned this issue Jan 19, 2021
Open
@katsel katsel added the blocked Another thing/issue has to be resolved before tackling this label Jan 19, 2021
@katsel
Copy link
Contributor

katsel commented Jan 19, 2021

Blocked by #108 unless we want hard-coded formatting.

@hmpf hmpf mentioned this issue Mar 4, 2022
Open
21 tasks
hmpf pushed a commit to hmpf/Argus that referenced this issue Nov 25, 2024
@johannaengland
Reformat middleware file using ruff
bc456a5 
This was forgotten in Uninett#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Another thing/issue has to be resolved before tackling this enhancement New feature or request notification Affects the notification system
Projects
None yet
Milestone
New notification system
Development

No branches or pull requests
2 participants
@katsel @hmpf