Connect phonenumber to notificationprofile #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 73.96% 74.15% +0.18%
==========================================
Files 34 34
Lines 1260 1327 +67
==========================================
+ Hits 932 984 +52
- Misses 328 343 +15
Continue to review full report at Codecov.
|
This was referenced Aug 7, 2020
hmpf
force-pushed
the
notify-phonenumber
branch
from
498550a to
ba22adc
Compare
hmpf
changed the title
|
Checking that a user may change the phone number is done identically with how it's done for timeslots and filters. |
hmpf
force-pushed
the
notify-phonenumber
branch
from
ba22adc to
01c66c5
Compare
ddabble
suggested changes
Aug 7, 2020
| @@ -167,6 +167,7 @@ class Media(models.TextChoices): | |||
| # TODO: support for multiple email addresses / phone numbers / Slack users | |||
| media = MultiSelectField(choices=Media.choices, min_choices=1, default=Media.EMAIL) | |||
| active = models.BooleanField(default=True) | |||
| phone_number = models.ForeignKey("argus_auth.PhoneNumber", on_delete=models.SET_NULL, blank=True, null=True) | |||
There was a problem hiding this comment.
Should we change this to parameter to a reference, to be consistent with the other ForeignKey fields?
Suggested change
| phone_number = models.ForeignKey("argus_auth.PhoneNumber", on_delete=models.SET_NULL, blank=True, null=True) | |
| phone_number = models.ForeignKey(to=PhoneNumber, on_delete=models.SET_NULL, blank=True, null=True) |
There was a problem hiding this comment.
Actually, I'd rather get rid of "to", and use strings whenever we point to something in a different app. Lowers chance of import-loops, since the strings are IIRC lazily imported.
hmpf
force-pushed
the
notify-phonenumber
branch
from
8f867cb to
7aef582
Compare
hmpf
force-pushed
the
notify-phonenumber
branch
from
7aef582 to
2da9cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not done: validating that a phone number is owned by the notificationprofile's owner.