Make it possible to filter events by a given list of event types #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When filtering notifications we have the choice to filter one event type This change makes it to filter by a list, so that we can get notifications about events of multiple types
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
==========================================
+ Coverage 84.50% 84.53% +0.02%
==========================================
Files 76 76
Lines 3808 3815 +7
==========================================
+ Hits 3218 3225 +7
Misses 590 590 ☔ View full report in Codecov by Sentry. |
lunkwill42
reviewed
May 14, 2024
|
True. As in: "event_type" should only have been visible on V2. "event_types" should only be visible on V2. The frontend seems to mostly use V1 though. |
johannaengland
approved these changes
May 14, 2024
It should never have been visible anyway.
hmpf
force-pushed
the
filter-by-event-type-list
branch
from
dc26ed7 to
56fc93a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #699
Continuation of #701