Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect information about frames in graph #34

Open
Rudde opened this issue Dec 22, 2022 · 2 comments
Open

Incorrect information about frames in graph #34

Rudde opened this issue Dec 22, 2022 · 2 comments

Comments

@Rudde
Copy link

Rudde commented Dec 22, 2022 •
edited
Loading

In this commit: 5f4bf68

A bug was introduced where the video frame type counts chars got incorrect, it counts everything as I Frames from this commit on. Video frame size graph is also broken and Video frame type sizes.

The bug is not in the code generating the graphs as it's unchanged, probably some data in the BDROM object which is changed.

frame-type-count

This line is causing the issue

BDInfo/BDInfo/BDROM/TSCodecAVC.cs

Line 45 in 5f4bf68

if (stream.IsInitialized) return;

Commenting it out seems to resolve it.
@Hellboy00000
Copy link

I can confirm that commenting this work. Thanks.

UniqProject added a commit that referenced this issue Jan 21, 2023
@UniqProject
Fix incorrect frame counts in reports / graph
3dfa4a7 
addresses #34
@UniqProject
Copy link
Owner

Problem fixed in the latest beta release v0.7.6.0b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@UniqProject @Rudde @Hellboy00000