Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ethereum-logo): centers Ethereum logo #1157

Merged
merged 1 commit into from
Oct 9, 2020
Merged

fix(ethereum-logo): centers Ethereum logo #1157

merged 1 commit into from
Oct 9, 2020

Conversation

JayWelsh
Copy link
Contributor

@JayWelsh JayWelsh commented Oct 9, 2020

Addresses the issue brought up on https://www.reddit.com/r/ethereum/comments/j7upcm/i_know_to_a_lot_of_you_it_might_seem_picky_but_as/

Previous Version:

ethereum-logo-off-center

Updated Version:

ethereum-logo

@vercel
Copy link

vercel bot commented Oct 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/uniswap-interface/1k64jmhy8
✅ Preview: https://uniswap-interface-git-fix-ethereum-logo-centering.uniswap.vercel.app

@moodysalem
Copy link
Contributor

Hmmm which one is official though? Symmetric != better

https://www.adweek.com/creativity/how-the-imperfections-in-googles-logo-are-what-make-it-perfect/

@JayWelsh
Copy link
Contributor Author

JayWelsh commented Oct 9, 2020

@moodysalem I think that it was obviously a mistake in the original image design, this is not a case of visual centering or a justified example, there seems to be pretty solid consensus in the Reddit thread that it isn't "for the best". I'll leave this PR open but I am not really prepared to put much effort into trying to make a case for why this should be merged, since it seems fairly straightforward. 🌈

To answer your question, neither of the images are official assets released by the Ethereum Foundation (assuming that is what you mean by "official"). But personally, I think the fixed version looks better.

@moodysalem moodysalem merged commit 6965598 into Uniswap:master Oct 9, 2020
crisog pushed a commit to Levinswap/levinswap-interface that referenced this pull request Feb 5, 2021
daniel-dev1990 pushed a commit to daniel-dev1990/uniswap-interface that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants