feat: routing api integration #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
July 19, 2021 12:17
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uniswap/uniswap-interface/EDnuTzCD3eV2NPkMJDq1qFpu4TGs |
justindomingue
changed the title
added 6 commits
July 26, 2021 15:32
added 2 commits
September 15, 2021 14:20
moodysalem
reviewed
Sep 15, 2021
| return { | ||
| tokenInAddress: tokenIn.wrapped.address, | ||
| tokenInChainId: tokenIn.chainId, | ||
| tokenOutAddress: tokenOut.wrapped.address, |
There was a problem hiding this comment.
hmm does the api not accept ETH as some kind of argument?
There was a problem hiding this comment.
it does accept ETH as tokenAddress but @willpote mentioned passing WETH will not change the outcome
There was a problem hiding this comment.
true, we do have currencyId function though and may want to be accurate if it doesn't cost us anything
added 2 commits
September 15, 2021 17:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch for routing integration.
Loading animation + invalidate stale data visually