Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotfix update setting user.router_preference for analytics #7459

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

just-toby
Copy link
Contributor

this is a hotfix including changes from #7458 and #7442

@just-toby just-toby requested review from a team and natew October 12, 2023 21:03
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 9:07pm

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #7459 (85ae71f) into releases/prod (a07556b) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Flag Coverage Δ
cloud-tests ?
unit-tests 42.43% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Oct 12, 2023

5 flaky tests on run #15001 ↗︎

0 118 0 0 Flakiness 5

Details:

fix: hotfix update setting user.router_preference for analytics
Project: Uniswap Interface Commit: 85ae71f80f
Status: Passed Duration: 05:18 💡
Started: Oct 12, 2023 9:10 PM Ended: Oct 12, 2023 9:16 PM
Flakiness  uniswapx.test.ts • 4 flaky tests • e2e

View Output Video

Test Artifacts
UniswapX Toggle > only displays uniswapx ui when setting is on Output Screenshots
UniswapX Orders > can swap exact-out trades using uniswapX Output Screenshots
UniswapX Eth Input > switches swap input to WETH after wrap Output Screenshots
UniswapX activity history > can view UniswapX order status progress in activity Output Screenshots
Flakiness  swapFlowLogging.test.ts • 1 flaky test • e2e

View Output Video

Test Artifacts
swap flow logging > completes two swaps and verifies the TTS logging for the first, plus all intermediate steps along the way Output Screenshots

Review all test suite changes for PR #7459 ↗︎

@just-toby just-toby merged commit b29968d into releases/prod Oct 12, 2023
@just-toby just-toby deleted the fix/user-prop-setting-prod branch October 12, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants