Add support for symbols containing unicode chars #176
Conversation
alexandrebini
changed the title
alexandrebini
changed the title
alexandrebini
force-pushed
the
bini/unicode-support
branch
from
57340ef
to
6c74d26
Compare
| @@ -63,6 +64,10 @@ describe('schema', () => { | |||
| checkSchema(emptyList, false); | |||
| }); | |||
|
|
|||
| it('works for empty names and symbols', () => { | |||
There was a problem hiding this comment.
I have many errors in the past I want to make amends
alexandrebini
force-pushed
the
bini/unicode-support
branch
from
f1786f5
to
ff5a257
Compare
| @@ -231,19 +231,33 @@ | |||
| "name": { | |||
| "type": "string", | |||
| "description": "The name of the token", | |||
| "minLength": 1, | |||
| "minLength": 0, | |||
| "maxLength": 40, | |||
There was a problem hiding this comment.
@zzmp btw, this limit isn't correct. You can have more than 40 chars and as far as I know there isn't a limit.
This pair is one https://dexscreener.com/polygon/0x841120E51aD43EfE489244728532854A352073aD
There was a problem hiding this comment.
Ok thanks I lost all my devices and I was able to recover some databases now
There was a problem hiding this comment.
Given there are existing applications that parse/store these fields from token lists, I think we should err on the side of caution in terms of what strings are allowed in the fields of a valid list (in the context of input sanitization). imo consumers of token lists should not have to worry about potentially malicious values in the list. So I would prefer we append the desired new characters/symbols to the original regex pattern rather than allowing essentially any string. Happy to hear your thoughts on this.
|
@matteenm I get your point. But I'm not sure if this package should be that strict. If you try to use for example the Polygon Tokens List (from their GitHub) you will see that the validation won't pass on symbols (it is also not passing for tags, but that's another issue). And here we are talking about an 'official' list. At DEX Screener we are tracking 40k+ tokens. If I need to whitelist every single special char I have, well, you know how that regexp will be in the end. I don't mind dropping this PR btw. I'm basically removing all special chars on my end in order to get the Uniswap widget working - otherwise, I can't even use the Polygon token list I mentioned. Let me know your thoughts! |
Add BeraLand
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "name": "My Token List", | |||
| @@ -231,19 +231,33 @@ | |||
| "name": { | |||
| "type": "string", | |||
| "description": "The name of the token", | |||
| "minLength": 1, | |||
| "examples": [ | ||
| "USD Coin" | ||
| ] | ||
| }, | ||
| "symbol": { | ||
| "type": "string", | ||
| "description": "The symbol for the token; must be alphanumeric", |
| "examples": [ | ||
| "USD Coin" | ||
| ] | ||
| }, | ||
| "symbol": { | ||
| "type": "string", | ||
| "description": "The symbol for the token; must be alphanumeric", | ||
| "pattern": "^[a-zA-Z0-9+\\-%/$.]+$", |
| "examples": [ | ||
| "USD Coin" | ||
| ] | ||
| }, | ||
| "symbol": { | ||
| "type": "string", | ||
| "description": "The symbol for the token; must be alphanumeric", | ||
| "pattern": "^[a-zA-Z0-9+\\-%/$.]+$", | ||
| "minLength": 1, |
#175