This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Pull auction params from client #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyborn
requested review from
ConjunctiveNormalForm,
zhongeric,
marktoda and
hensha256
as code owners
| @@ -85,7 +85,7 @@ export abstract class DutchQuote<T extends DutchQuoteRequest> implements IQuote | |||
| public readonly createdAt: string; | |||
| public derived: DutchQuoteDerived; | |||
| public routingType: RoutingType.DUTCH_LIMIT | RoutingType.DUTCH_V2; | |||
| public abstract readonly defaultDeadlienBufferInSecs: number; | |||
| public abstract readonly defaultDeadlineBufferInSecs: number; | |||
There was a problem hiding this comment.
shouldn't quoteConfig cover all chains and routingTypes, so that this is no longer needed?
There was a problem hiding this comment.
The quoteConfig doesn't have a default value; it currently acts as an override.
ConjunctiveNormalForm
approved these changes
May 22, 2024
| @@ -335,6 +335,82 @@ describe('DutchQuoteContext', () => { | |||
| expect((quote?.toJSON() as DutchQuoteDataJSON).orderInfo.exclusiveFiller).toEqual(filler); | |||
| }); | |||
|
|
|||
| it('uses synthetic if worse with forceOpenOrders=true and switch=false', async () => { | |||
There was a problem hiding this comment.
nit: wdym by switch=false?
There was a problem hiding this comment.
There used to be a service that URA would call that would say whether synthetic orders were enabled or not: SyntheticStatusProvider - it's now a noop in the code with DisabledSyntheticStatusProvider. This test (and others like it use makeProviders(false) to simulate a false response from that API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client managed auction params:
forceOpenOrders- Setting true will force an Open Order and skip RFQpriceImprovementBps- Setting this will override whatever the server would have defaulted to for price improvementExisting:
deadlineBufferSecsOther changes:
skipRFQtoforceOpenOrdersinChainConfigManager.ts