This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
feat: support zora #425
Merged
feat: support zora #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
requested review from
ConjunctiveNormalForm,
zhongeric,
marktoda,
hensha256 and
codyborn
as code owners
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@uniswap/router-sdk@1.9.0, npm/@uniswap/sdk-core@4.2.0, npm/@uniswap/smart-order-router@3.26.0, npm/@uniswap/universal-router-sdk@1.9.0, npm/@uniswap/v2-sdk@4.3.0 |
jsy1218
force-pushed
the
jsy1218/support-zora
branch
from
da5057c to
7714876
Compare
|
Update: Sorry from the failed URA unit tests, I realized the sdks versions from router-sdk and from SOR are inconsistent, hence I'm updating SOR to make it consistent first Uniswap/smart-order-router#586. |
codyborn
reviewed
May 22, 2024
codyborn
approved these changes
May 22, 2024
jsy1218
force-pushed
the
jsy1218/support-zora
branch
from
7714876 to
a21afb0
Compare
I replied and explained there. Good question though. Will merge this PR tmrw morning during EST business hour. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are supporting Zora at URA level. New Zora integ-tests passed locally: https://app.warp.dev/block/ORkGYAIoQj62tdD8vMUm9B