feat: use fast exponentiation for better perf #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces two functions that cause a lot of slowness due to running a lot of BigDecimal operations with more efficient versions.
fastExponentiation
replaces thebigDecimalExponated
with an implementation of exponentiation by squaring in order to get the number of multiplications from O(N) to O(log N) on the power. This is particularly effective for large powers in the hundreds or thousands.exponentToBigDecimal
replaces the 10^N computation with a string-based implementation. This sounds weird at first, but it helps with performance because it replaces N calls to BigDecimal operations with only one at the end.A possible further optimization to the
fastExponentiation
is to expose that as a WebAssembly host function at the graph-node level. This should help optimize performance further by removing the need to pass BigDecimal values back and forth between the AssemblyScript handler function and the RustBigDecimal.times
host function.