Optimize absTick calculation in TickMath.getSqrtPriceAtTick
#663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuhuiluo
force-pushed
the
get-sqrt-ratio-at-tick-0
branch
from
c6a37ea
to
4ec192c
Compare
hensha256
reviewed
May 20, 2024
| @@ -46,7 +46,15 @@ library TickMath { | |||
| /// at the given tick | |||
| function getSqrtPriceAtTick(int24 tick) internal pure returns (uint160 sqrtPriceX96) { | |||
| unchecked { | |||
| uint256 absTick = tick < 0 ? uint256(-int256(tick)) : uint256(int256(tick)); | |||
There was a problem hiding this comment.
could you add 1 test to show that the behaviour for type(int24).min is unchanged - just bc thats the 1 number that performs -1 weirdly. Something like
function test_getSqrtPriceAtTick_throwsForMinIn24() public {
vm.expectRevert(TickMath.InvalidTick.selector);
tickMath.getSqrtPriceAtTick(type(int24).min);
}
There was a problem hiding this comment.
Will do. But note that in both the original code and the current code, before negation type(int24).min will first be sign-extended to int256. Negating type(int24).min as a int256 would not revert. However, it will be rejected after comparing to MAX_TICK.
hensha256
previously approved these changes
May 20, 2024
The getSqrtPriceAtTick function in the TickMath library has been refactored with a more efficient assembly implementation. This optimization significantly reduces the gas usage by using bitwise operations for computing absolute value of a tick.
The new test case asserts that the function `getSqrtPriceAtTick` throws an error when called with the minimum valid input. This ensures that the function behaves as expected for all possible input values, enhancing the overall test coverage.
shuhuiluo
force-pushed
the
get-sqrt-ratio-at-tick-0
branch
from
58f0ee9
to
174b299
Compare
hensha256
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #273.
Related Issue
Which issue does this pull request resolve?
Description of changes
The getSqrtPriceAtTick function in the TickMath library has been refactored with a more efficient assembly implementation. This optimization significantly reduces the gas usage by using bitwise operations for computing absolute value of a tick.