Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import v3-sdk to ffi #682

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

import v3-sdk to ffi #682

wants to merge 8 commits into from

Conversation

dianakocsis
Copy link
Contributor

@dianakocsis dianakocsis commented May 20, 2024 •
edited
Loading

Related Issue

Which issue does this pull request resolve?
importing v3-sdk to ffi

Description of changes

To Run tests:
foundryup --pr 7941
forge test --isolate --no-match-path 'test/js-scripts/**/*'

@socket-security Socket Security
Copy link

socket-security bot commented May 20, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ethersproject/abi@5.7.0 None 0 498 kB ricmoo
npm/@ethersproject/abstract-provider@5.7.0 None 0 61 kB ricmoo
npm/@ethersproject/abstract-signer@5.7.0 None 0 82.2 kB ricmoo
npm/@ethersproject/address@5.7.0 None 0 33.1 kB ricmoo
npm/@ethersproject/base64@5.7.0 None 0 11.3 kB ricmoo
npm/@ethersproject/basex@5.7.0 None 0 30.1 kB ricmoo
npm/@ethersproject/bignumber@5.7.0 None 0 143 kB ricmoo
npm/@ethersproject/bytes@5.7.0 None 0 80.9 kB ricmoo
npm/@ethersproject/constants@5.7.0 None 0 18.7 kB ricmoo
npm/@ethersproject/hash@5.7.0 None 0 257 kB ricmoo
npm/@ethersproject/hdnode@5.7.0 None 0 80.7 kB ricmoo
npm/@ethersproject/json-wallets@5.7.0 None +1 2.56 MB ricmoo
npm/@ethersproject/keccak256@5.7.0 None +1 59 kB ricmoo
npm/@ethersproject/logger@5.7.0 None 0 69.5 kB ricmoo
npm/@ethersproject/networks@5.7.1 None 0 47.5 kB ricmoo
npm/@ethersproject/pbkdf2@5.7.0 None 0 17.4 kB ricmoo
npm/@ethersproject/properties@5.7.0 None 0 31 kB ricmoo
npm/@ethersproject/random@5.7.0 None 0 17.3 kB ricmoo
npm/@ethersproject/rlp@5.7.0 None 0 29.6 kB ricmoo
npm/@ethersproject/sha2@5.7.0 None 0 21.7 kB ricmoo
npm/@ethersproject/signing-key@5.7.0 None 0 244 kB ricmoo
npm/@ethersproject/solidity@5.7.0 None 0 23.2 kB ricmoo
npm/@ethersproject/strings@5.7.0 None 0 119 kB ricmoo
npm/@ethersproject/transactions@5.7.0 None 0 89.6 kB ricmoo
npm/@ethersproject/web@5.7.1 network 0 128 kB ricmoo
npm/@ethersproject/wordlists@5.7.0 None 0 390 kB ricmoo
npm/@noble/hashes@1.2.0 None 0 736 kB paulmillr
npm/@noble/secp256k1@1.7.1 None 0 111 kB paulmillr
npm/@uniswap/v3-periphery@1.4.4 None +5 5.52 MB mtoda
npm/@uniswap/v3-sdk@3.11.2 environment Transitive: eval, filesystem, network, shell, unsafe +201 184 MB uniswap-labs-service-account
npm/ansi-styles@4.3.0 None +2 50.9 kB sindresorhus
npm/bn.js@5.2.1 None 0 99 kB fanatid
npm/camelcase@6.3.0 None 0 11.7 kB sindresorhus
npm/chokidar@3.6.0 environment, filesystem +10 408 kB paulmillr
npm/cipher-base@1.0.4 None 0 7.95 kB cwmma
npm/create-hash@1.2.0 Transitive: environment +5 163 kB cwmma
npm/create-hmac@1.1.7 None 0 5.81 kB cwmma
npm/debug@4.3.4 environment +1 49.2 kB qix
npm/decimal.js@10.4.3 None 0 283 kB mikemcl
npm/ethereumjs-util@6.2.1 Transitive: environment, filesystem +23 7.14 MB holgerd77
npm/ethers@5.7.2 Transitive: network +5 12.2 MB ricmoo
npm/ethjs-util@0.1.6 None +2 244 kB silentcicero
npm/fp-ts@1.19.3 None 0 2 MB gcanti
npm/graceful-fs@4.2.11 environment, filesystem 0 32.5 kB isaacs
npm/is-glob@4.0.3 None +1 19.8 kB phated
npm/keccak@3.0.4 Transitive: environment, filesystem +5 1.74 MB fanatid
npm/normalize-path@3.0.0 None 0 9.22 kB jonschlinkert
npm/picomatch@2.3.1 None 0 90 kB mrmlnc
npm/resolve@1.17.0 filesystem +1 110 kB ljharb
npm/ripemd160@2.0.2 Transitive: environment +4 160 kB dcousens
npm/safe-buffer@5.2.1 None 0 32.1 kB feross
npm/sha.js@2.4.11 None 0 31.1 kB dcousens
npm/source-map-support@0.5.21 filesystem +2 895 kB linusu
npm/string-width@4.2.3 None +2 58.4 kB sindresorhus
npm/strip-ansi@6.0.1 None +1 9.64 kB sindresorhus
npm/yargs-parser@20.2.4 environment, filesystem 0 120 kB oss-bot

🚮 Removed packages: npm/@ethersproject/abi@5.5.0, npm/@ethersproject/abstract-provider@5.5.1, npm/@ethersproject/abstract-signer@5.5.0, npm/@ethersproject/address@5.5.0, npm/@ethersproject/base64@5.5.0, npm/@ethersproject/basex@5.5.0, npm/@ethersproject/bignumber@5.5.0, npm/@ethersproject/bytes@5.5.0, npm/@ethersproject/constants@5.5.0, npm/@ethersproject/hash@5.5.0, npm/@ethersproject/hdnode@5.5.0, npm/@ethersproject/json-wallets@5.5.0, npm/@ethersproject/keccak256@5.5.0, npm/@ethersproject/logger@5.5.0, npm/@ethersproject/networks@5.5.1, npm/@ethersproject/pbkdf2@5.5.0, npm/@ethersproject/properties@5.5.0, npm/@ethersproject/random@5.5.0, npm/@ethersproject/rlp@5.5.0, npm/@ethersproject/sha2@5.5.0, npm/@ethersproject/signing-key@5.5.0, npm/@ethersproject/strings@5.5.0, npm/@ethersproject/transactions@5.5.0, npm/@ethersproject/web@5.5.1, npm/@ethersproject/wordlists@5.5.0, npm/decimal.js@10.3.1, npm/ethers@5.5.2

View full report↗︎

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

Forge code coverage:

File % Lines % Statements % Branches % Funcs
src/ERC6909.sol 91.30% (21/23) 85.71% (24/28) 100.00% (4/4) 85.71% (6/7)
src/ERC6909Claims.sol 100.00% (6/6) 100.00% (8/8) 100.00% (4/4) 100.00% (1/1)
src/Extsload.sol 100.00% (0/0) 100.00% (0/0) 100.00% (0/0) 100.00% (3/3)
src/Exttload.sol 100.00% (0/0) 100.00% (0/0) 100.00% (0/0) 50.00% (1/2)
src/NoDelegateCall.sol 100.00% (3/3) 100.00% (5/5) 100.00% (2/2) 100.00% (3/3)
src/PoolManager.sol 100.00% (83/83) 99.11% (111/112) 97.22% (35/36) 100.00% (18/18)
src/ProtocolFees.sol 100.00% (20/20) 97.06% (33/34) 91.67% (11/12) 100.00% (6/6)
src/libraries/BitMath.sol 100.00% (47/47) 100.00% (57/57) 100.00% (36/36) 100.00% (2/2)
src/libraries/CurrencyDelta.sol 100.00% (4/4) 100.00% (6/6) 100.00% (0/0) 100.00% (3/3)
src/libraries/CurrencySettleTake.sol 100.00% (10/10) 100.00% (10/10) 50.00% (3/6) 100.00% (2/2)
src/libraries/CustomRevert.sol 100.00% (0/0) 100.00% (0/0) 100.00% (0/0) 100.00% (6/6)
src/libraries/FullMath.sol 100.00% (28/28) 100.00% (32/32) 100.00% (8/8) 100.00% (2/2)
src/libraries/Hooks.sol 100.00% (79/79) 100.00% (144/144) 100.00% (58/58) 100.00% (15/15)
src/libraries/LPFeeLibrary.sol 100.00% (10/10) 100.00% (18/18) 100.00% (4/4) 100.00% (7/7)
src/libraries/LiquidityMath.sol 100.00% (2/2) 100.00% (1/1) 100.00% (1/1) 100.00% (1/1)
src/libraries/Lock.sol 100.00% (4/4) 100.00% (4/4) 100.00% (0/0) 100.00% (3/3)
src/libraries/NonZeroDeltaCount.sol 100.00% (6/6) 100.00% (6/6) 100.00% (0/0) 100.00% (3/3)
src/libraries/ParseBytes.sol 100.00% (3/3) 100.00% (3/3) 100.00% (0/0) 100.00% (3/3)
src/libraries/Pool.sol 99.34% (151/152) 98.26% (169/172) 94.32% (83/88) 100.00% (13/13)
src/libraries/Position.sol 100.00% (11/11) 100.00% (12/12) 100.00% (4/4) 100.00% (2/2)
src/libraries/ProtocolFeeLibrary.sol 100.00% (4/4) 100.00% (6/6) 100.00% (0/0) 100.00% (4/4)
src/libraries/Reserves.sol 100.00% (8/8) 100.00% (13/13) 100.00% (6/6) 100.00% (3/3)
src/libraries/SafeCast.sol 100.00% (10/10) 100.00% (26/26) 100.00% (10/10) 100.00% (6/6)
src/libraries/SqrtPriceMath.sol 100.00% (37/37) 100.00% (53/53) 82.35% (14/17) 100.00% (9/9)
src/libraries/StateLibrary.sol 100.00% (65/65) 100.00% (94/94) 100.00% (4/4) 100.00% (14/14)
src/libraries/SwapMath.sol 100.00% (24/24) 100.00% (31/31) 100.00% (12/12) 100.00% (2/2)
src/libraries/TickBitmap.sol 100.00% (17/17) 100.00% (23/23) 100.00% (3/3) 100.00% (4/4)
src/libraries/TickMath.sol 100.00% (95/95) 100.00% (140/140) 100.00% (43/43) 100.00% (4/4)
src/libraries/TransientStateLibrary.sol 88.89% (8/9) 85.71% (12/14) 100.00% (0/0) 75.00% (3/4)
src/libraries/UnsafeMath.sol 100.00% (1/1) 100.00% (1/1) 100.00% (0/0) 100.00% (1/1)
src/types/BalanceDelta.sol 100.00% (2/2) 100.00% (2/2) 100.00% (0/0) 100.00% (2/2)
src/types/BeforeSwapDelta.sol 100.00% (2/2) 100.00% (2/2) 100.00% (0/0) 100.00% (2/2)
src/types/Currency.sol 100.00% (15/15) 95.83% (23/24) 100.00% (10/10) 100.00% (6/6)
src/types/PoolId.sol 100.00% (1/1) 100.00% (1/1) 100.00% (0/0) 100.00% (1/1)
src/types/Slot0.sol 100.00% (8/8) 100.00% (8/8) 100.00% (0/0) 100.00% (8/8)
Total 85.04% (1427/1678) 85.07% (1932/2271) 62.50% (515/824) 78.95% (345/437)

snreynolds
snreynolds reviewed May 22, 2024
View reviewed changes
test/libraries/FullMath.t.sol Outdated Show resolved Hide resolved
test/js-scripts/package.json Outdated Show resolved Hide resolved
snreynolds
snreynolds reviewed May 23, 2024
View reviewed changes
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! would just add that in-line config.

& looks like we need to fix github actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snreynolds snreynolds snreynolds left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dianakocsis @snreynolds @hensha256