Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't delete existing sftp.json configuration file #529

Closed
tyuldashev opened this issue Nov 9, 2022 · 1 comment · Fixed by #537
Closed

Don't delete existing sftp.json configuration file #529

tyuldashev opened this issue Nov 9, 2022 · 1 comment · Fixed by #537
Assignees
@alexey-utkin
Labels
bug Something isn't working verified Bug fix is verified vscode-plugin Issue related to VScode plugin

Comments

@tyuldashev
Copy link
Collaborator

Description
In case user leaves empty SFTP port in UTBot quick setup wizard, UTBot removes sftp config file even it was pre-existing.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure you already have .vscode/sftp.json configuration file
  2. Start UTBot Quickstart wizard
  3. Proceed to 'Server Setup' page
  4. Leave SFTP port field empty and click 'Next' button

Actual behavior
.vscode/sftp.json file disappears

Expected behavior
Exiting sftp.json left as is, because it could be created for reason. For example user wants to control when and what uploaded to the server. It may also contain information and settings which are necessary for user.

Basically I assume that UBot should not remove anything which wasn't created by the bot itself.
@tyuldashev tyuldashev added the bug Something isn't working label Nov 9, 2022
@tyuldashev tyuldashev moved this to Todo in UTBot C/C++ Nov 9, 2022
@ladisgin ladisgin added the vscode-plugin Issue related to VScode plugin label Nov 11, 2022
alexey-utkin added a commit that referenced this issue Nov 14, 2022
@alexey-utkin
Fixes for #533, #530, #529 (partially), #528
566d633 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)

Signed-off-by: Alexey Utkin <alexey.utkin@gmail.com>
@alexey-utkin alexey-utkin mentioned this issue Nov 14, 2022
Merged
@alexey-utkin alexey-utkin linked a pull request Nov 14, 2022 that will close this issue
Fixes for #533, #530, #529 (partially), #528 #537
Merged
alexey-utkin added a commit that referenced this issue Nov 15, 2022
@alexey-utkin
Fixes for #533, #530, #529 (partially), #528 PR(#537)
59b658f 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)
Repository owner moved this from Todo to Done in UTBot C/C++ Nov 15, 2022
@tyuldashev
Copy link
Collaborator Author

The backup with extension .old is created but I found bigger problem with current SFTP configuration - #546.

@tyuldashev tyuldashev added the verified Bug fix is verified label Nov 21, 2022
Lana243 pushed a commit that referenced this issue Nov 21, 2022
@alexey-utkin @Lana243
Fixes for #533, #530, #529 (partially), #528 PR(#537)
c0569df 
- SFTP notifications have wrong icons #533
- Fields on 'Server Setup' page of wizard are misaligned #530
- Wizard has no 'Previous' buttons #528
- Don't delete existing sftp.json configuration file #529 (partially - for user config we make a backup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-utkin alexey-utkin

Labels
bug Something isn't working verified Bug fix is verified vscode-plugin Issue related to VScode plugin
Projects
UTBot C/C++
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for #533, #530, #529 (partially), #528 UnitTestBot/UTBotCpp
3 participants
@alexey-utkin @tyuldashev @ladisgin