Skip to content

Fix compare char with string literal in for loop #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023
+6 −3
Merged

Fix compare char with string literal in for loop #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server/src/visitors/AbstractValueViewVisitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ namespace visitor {
visitArrayElementAfter(newType, newName, newView, newAccess, depth + 1);
}
}

void AbstractValueViewVisitor::visitCString(const types::Type &type,
const std::string &name,
const tests::AbstractValueView *view,
Expand Down
8 changes: 5 additions & 3 deletions server/src/visitors/ParametrizedAssertsVisitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ namespace visitor {
PrinterUtils::ACTUAL, functionCall, std::nullopt, true,
additionalPointersCount);
printer->strDeclareVar(type.typeName(),
PrinterUtils::fillVarName(access, PrinterUtils::EXPECTED), value);
PrinterUtils::fillVarName(access, PrinterUtils::EXPECTED), value);
} else {
printer->ss << value << NL;
}
Expand All @@ -110,7 +110,8 @@ namespace visitor {
additionalPointersCount);
const auto &gtestMacro = predicateMapping.at(predicate);
auto signature =
processExpect(type, gtestMacro, {view->getEntryValue(printer), getDecorateActualVarName(access)});
processExpect(type, gtestMacro,
{view->getEntryValue(printer), getDecorateActualVarName(access)});
signature = changeSignatureToNullCheck(signature, type, view, access);
printer->strFunctionCall(signature.name, signature.args, SCNL, std::nullopt, true,
0, std::nullopt, inUnion);
Expand All @@ -121,7 +122,8 @@ namespace visitor {
}
const auto &gtestMacro = predicateMapping.at(predicate);
auto signature = processExpect(type, gtestMacro,
{getDecorateActualVarName(access), view->getEntryValue(printer)});
{getDecorateActualVarName(access),
PrinterUtils::fillVarName(access, PrinterUtils::EXPECTED)});
signature = changeSignatureToNullCheck(signature, type, view, access);
printer->strFunctionCall(signature.name, signature.args, SCNL, std::nullopt, true, 0,
std::nullopt, inUnion);
Expand Down