Skip to content

Improve overloadings check in generated code #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
EgorkaKulikov opened this issue Jul 1, 2022 · 0 comments · Fixed by #503
Closed

Improve overloadings check in generated code #370

EgorkaKulikov opened this issue Jul 1, 2022 · 0 comments · Fixed by #503
Assignees
@Vassiliy-Kudryashov
Labels
comp-codegen Issue is related to code generator ctg-enhancement New feature, improvement or change request

Comments

@EgorkaKulikov
Copy link
Collaborator

Description

Method ClassId.allMethods and its usage in codegen requires refactoring

Expected behavior

For now, to check functions overloadings and cast null arguments to their types in case we have overloadings with the same number of parameters, we filter all declared methods from class and all its ancestors. But actually, it is the wrong way because we count not only overloadings but overridings too. So, we should filter overloadings before.

Context

Migrated from Jira, issue 1458.
@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-codegen Issue is related to code generator labels Jul 1, 2022
@EgorkaKulikov EgorkaKulikov self-assigned this Jul 1, 2022
@EgorkaKulikov EgorkaKulikov moved this to Todo in UTBot Java Jul 1, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov moved this from Todo to In Progress in UTBot Java Jul 12, 2022
Vassiliy-Kudryashov added a commit that referenced this issue Jul 12, 2022
@Vassiliy-Kudryashov
Improve overloadings check in generated code #370
2a21465
@Vassiliy-Kudryashov Vassiliy-Kudryashov mentioned this issue Jul 12, 2022
Merged
3 tasks
@Vassiliy-Kudryashov Vassiliy-Kudryashov linked a pull request Jul 12, 2022 that will close this issue
Improve overloadings check in generated code #370 #503
Merged
3 tasks
Vassiliy-Kudryashov added a commit that referenced this issue Jul 13, 2022
@Vassiliy-Kudryashov
Improve overloadings check in generated code #370 (#503)
b7bc926
Repository owner moved this from In Progress to Done in UTBot Java Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vassiliy-Kudryashov Vassiliy-Kudryashov

Labels
comp-codegen Issue is related to code generator ctg-enhancement New feature, improvement or change request
Projects
UTBot Java
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve overloadings check in generated code #370 UnitTestBot/UTBotJava
2 participants
@Vassiliy-Kudryashov @EgorkaKulikov