Skip to content

Engine process #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Engine process #1022

wants to merge 9 commits into from

Conversation

Domonion
Copy link
Collaborator

Moved engine process out of the main idea process. Changes include:

  1. Reactive settings
  2. Removing all JDK9+ api calls to support out-of-the process execution on JDK8
  3. Refactored client protocol initialization, ClientProcessBuilder introduced
  4. Big refactoring

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

val (methods, className) = ReadAction.nonBlocking<Pair<List<ExecutableId>, String?>> {
val canonicalName = srcClass.canonicalName
// todo how bad is it?
val clazz = classLoader.loadClass(canonicalName).kotlin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't allow running project with JDK-17 on IDEA with JDK-11.

@alisevych
Copy link
Member

alisevych commented Sep 28, 2022

I've built plugin from this branch and installed it on IntelliJ IDEA 2022.1.4
Found a bug:
Error popup "Failed to save tests report". When OK is pressed SARIF-file is saved.
image

@alisevych
Copy link
Member

alisevych commented Sep 28, 2022

Also one more bug found by @Markoutte :
Cancel Test generation is ignored - process continues up to the end.
image

@alisevych
Copy link
Member

Found issue:
Concrete execution logs contain many debug information.
Log on test generation for Recursion class weights 1,5 GB (!)

Moved engine process out of the main idea process. Changes include:
1. Reactive settings
2. Removing all JDK9+ api calls to support out-of-the process execution
   on JDK8
3. Refactored client protocol initialization, ClientProcessBuilder
   introduced
4. Big refactoring
simple fixes
logs for ci, commit will be reverted
deadlock fix
more jdk api fixes
removed reflexion, proxied all reflection calls to another process, some fixes, removed test generation report, sarif generation proxied to another process, fixed logs
enabled test generation report, optimized kryo serialization - UtMethodTestCase no more send to main process, access it through testSetsId
@Domonion Domonion force-pushed the kononov-engine-process-idea branch from f376b1a to ef7a1ab Compare October 3, 2022 13:08
[utbot-rd]
threading fix

[utbot-rd]
merge fixes
@Domonion Domonion force-pushed the kononov-engine-process-idea branch from 4d0c8f0 to 067da31 Compare October 4, 2022 07:36
@Domonion
Copy link
Collaborator Author

Domonion commented Oct 4, 2022

rolling to #1067

@Domonion Domonion closed this Oct 4, 2022
@Domonion Domonion deleted the kononov-engine-process-idea branch December 6, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants