-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modificators processing in AssembleModelGenerator and UtBotFieldModificatorsSearcher corrected #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorkaKulikov
force-pushed
the
egor/fms_default_package
branch
from
September 29, 2022 08:08
02fdc9e
to
122d408
Compare
EgorkaKulikov
force-pushed
the
egor/fms_default_package
branch
from
September 30, 2022 15:40
c4444b7
to
6049c5f
Compare
EgorkaKulikov
changed the title
Searcher of field modificators fixed for default package.
Modificators processing in AssembleModelGenerator and UtBotFieldModificatorsSearcher corrected
Sep 30, 2022
EgorkaKulikov
force-pushed
the
egor/fms_default_package
branch
from
September 30, 2022 16:10
6049c5f
to
32a3394
Compare
…ssembleModelGenerator
EgorkaKulikov
force-pushed
the
egor/fms_default_package
branch
from
September 30, 2022 16:11
c88756c
to
b12f7c3
Compare
volivan239
requested changes
Oct 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, but please check the comments.
utbot-framework/src/main/kotlin/org/utbot/framework/assemble/AssembleModelGenerator.kt
Outdated
Show resolved
Hide resolved
...amework/src/main/kotlin/org/utbot/framework/modifications/UtBotFieldsModificatorsSearcher.kt
Outdated
Show resolved
Hide resolved
...amework/src/main/kotlin/org/utbot/framework/modifications/UtBotFieldsModificatorsSearcher.kt
Outdated
Show resolved
Hide resolved
volivan239
approved these changes
Oct 3, 2022
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
…icatorsSearcher corrected (UnitTestBot#1029) * Improve modificators analysis in UtBotFieldModificatorsSearcher and AssembleModelGenerator * Apply review comments * Fixed test * One more correction for package names
AbdullinAM
pushed a commit
to AbdullinAM/UTBotJava
that referenced
this pull request
Oct 17, 2022
…icatorsSearcher corrected (UnitTestBot#1029) * Improve modificators analysis in UtBotFieldModificatorsSearcher and AssembleModelGenerator * Apply review comments * Fixed test * One more correction for package names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Searcher of field modificators fixed for default package: in the previous implementation it considered all modificators appropriate if they are located in a default package.
Fixes # (1024)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Automated Testing
UtBotFieldModificatorsTest
Manual Scenario
Repeat the scenario described in the mentioned feature with fuzzer and concrete executor turned off.