Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modificators processing in AssembleModelGenerator and UtBotFieldModificatorsSearcher corrected #1029

Merged
merged 6 commits into from
Oct 3, 2022

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

Searcher of field modificators fixed for default package: in the previous implementation it considered all modificators appropriate if they are located in a default package.

Fixes # (1024)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

UtBotFieldModificatorsTest

Manual Scenario

Repeat the scenario described in the mentioned feature with fuzzer and concrete executor turned off.

@EgorkaKulikov EgorkaKulikov force-pushed the egor/fms_default_package branch from 02fdc9e to 122d408 Compare September 29, 2022 08:08
@EgorkaKulikov EgorkaKulikov marked this pull request as draft September 29, 2022 15:24
@EgorkaKulikov EgorkaKulikov marked this pull request as ready for review September 29, 2022 22:10
@EgorkaKulikov EgorkaKulikov marked this pull request as draft September 30, 2022 08:21
@EgorkaKulikov EgorkaKulikov force-pushed the egor/fms_default_package branch from c4444b7 to 6049c5f Compare September 30, 2022 15:40
@EgorkaKulikov EgorkaKulikov marked this pull request as ready for review September 30, 2022 16:05
@EgorkaKulikov EgorkaKulikov changed the title Searcher of field modificators fixed for default package. Modificators processing in AssembleModelGenerator and UtBotFieldModificatorsSearcher corrected Sep 30, 2022
@EgorkaKulikov EgorkaKulikov force-pushed the egor/fms_default_package branch from 6049c5f to 32a3394 Compare September 30, 2022 16:10
@EgorkaKulikov EgorkaKulikov force-pushed the egor/fms_default_package branch from c88756c to b12f7c3 Compare September 30, 2022 16:11
Copy link
Collaborator

@volivan239 volivan239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, but please check the comments.

@EgorkaKulikov EgorkaKulikov merged commit 19b0f78 into main Oct 3, 2022
@EgorkaKulikov EgorkaKulikov deleted the egor/fms_default_package branch October 3, 2022 13:30
@alisevych alisevych added this to the 2022.10.1 Release milestone Oct 7, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
…icatorsSearcher corrected (UnitTestBot#1029)

* Improve modificators analysis in UtBotFieldModificatorsSearcher and AssembleModelGenerator

* Apply review comments

* Fixed test

* One more correction for package names
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
…icatorsSearcher corrected (UnitTestBot#1029)

* Improve modificators analysis in UtBotFieldModificatorsSearcher and AssembleModelGenerator

* Apply review comments

* Fixed test

* One more correction for package names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants